Skip to content

[DataFactory]Add Binary Dataset in swagger#6631

Merged
praries880 merged 4 commits intoAzure:masterfrom
TinaHu1:binary
Jul 18, 2019
Merged

[DataFactory]Add Binary Dataset in swagger#6631
praries880 merged 4 commits intoAzure:masterfrom
TinaHu1:binary

Conversation

@TinaHu1
Copy link
Copy Markdown
Contributor

@TinaHu1 TinaHu1 commented Jul 16, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci azuresdkci requested a review from praries880 July 16, 2019 05:30
@AutorestCI AutorestCI mentioned this pull request Jul 16, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI AutorestCI mentioned this pull request Jul 16, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5255

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Jul 16, 2019

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jul 16, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2019
KrisBash
KrisBash approved these changes Jul 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns with the definitions defined, although it is unclear to me how they are used if not referenced in API request/response. I assume an enum needs to be updated in a future iteration?

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 16, 2019
@TinaHu1
Copy link
Copy Markdown
Contributor Author

TinaHu1 commented Jul 17, 2019

No concerns with the definitions defined, although it is unclear to me how they are used if not referenced in API request/response. I assume an enum needs to be updated in a future iteration?

About the referenced,, we use "x-ms-discriminator-value" to extend the "Dataset", and the "Dataset" has already referenced in API request at specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json. So the newly added one can be used in API request. DataFactory always add new connector by this way because we add new connector type in high frequency.

@TinaHu1
Copy link
Copy Markdown
Contributor Author

TinaHu1 commented Jul 17, 2019

@praries880 Could you help merge this PR? Thanks.

@TinaHu1
Copy link
Copy Markdown
Contributor Author

TinaHu1 commented Jul 18, 2019

@praries880 Could you help merge this PR? We need to merge this change as soon as possible for our SDK release. Thanks!

@praries880 praries880 merged commit 90ec2b9 into Azure:master Jul 18, 2019
@hvermis hvermis mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@KrisBash KrisBash KrisBash approved these changes

@praries880 praries880 praries880 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@praries880 praries880

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TinaHu1 @AutorestCI @azuresdkci @KrisBash @praries880 @TinaHu18